Added FrequencyEnum for Reset Frequency Values #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Enums are not supported in PHP 8.0 and PHP 8.0 is required for Laravel 8 and 9. |
|
I didn't check the compatibility, that's my fault. |
|
This is a great package I found through Laravel Daily youtube channel. I think we can make use of php class Frequency (that what we used prior of enums introduced in php 8.1). This would work and backward compatible too. |
|
hey @aneeskhan47, please feel free to submit a PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Introduced a new enum FrequencyEnum in the file src/Enum/FrequencyEnum.php.
The FrequencyEnum defines the possible values for the reset_frequency column.
Added the following values in the enum:
EVERY_SECOND= 'every second'EVERY_MINUTE= 'every minute'EVERY_HOUR= 'every hour'EVERY_DAY= 'every day'EVERY_WEEK= 'every week'EVERY_TWO_WEEKS= 'every two weeks'EVERY_MONTH= 'every month'EVERY_QUARTER= 'every quarter'EVERY_SIX_MONTHS= 'every six months'EVERY_YEAR= 'every year'Benefits:
Centralized management of reset frequency values.
Simplifies handling time-based operations with the integration of Carbon date-time library.
Ensures consistency and reduces the risk of errors associated with manual time calculations.
Please review the changes and let me know if any further modifications are needed.